Bug Moderation + Tagging/Mentions Bug

[mirageboss]

Hi DBTech, I installed the plugin as a trial, but found when a tagged post had been soft-deleted, the user could still see the mention/tag in their "notifications" tab, and also on their profile. When the thread was moved to a hidden forum, the mention/tag disappeared from their view (from their profile, and from their notifications drop-down). Is there a way to make if the post is soft-deleted, it too hides the mention/tag?

(System is vBulletin 4.1.x)
Note: Have disabled plugin due to this issue.

 

[Fillip H.]

We'll look into it for the next update / hotfix

 

[mirageboss]

Any idea when this will be? Just trying to get a timeframe

 

[Ozzy47]

As a rule we don't give time frames for updates, sorry

 

[Fillip H.]

I've pushed a hotfix to v3.0.5, let me know if this works for you

 

[mirageboss]

No luck.

Me logged in to user account Test (different browser also): Droplr • Screenshot on 12.8.2012 at 6.33.41 PM.png
Me on admin account showing its deleted: Droplr • Screenshot on 12.8.2012 at 6.34.12 PM.png

Thanks

 

[Fillip H.]

It works fine for me with this change in place. Please try deleting all downloaded .zip files and re-download, re-extract then re-upload the files.

The important file in this case is /dbtech/usertag/includes/class_profileblock.php - it should have AND post.visible = 1 in it.

 

[mirageboss]

Tried still same problem.

		// Count number of users
		$count = $this->registry->db->query_first_slave("
			SELECT COUNT(*) AS total
			FROM " . TABLE_PREFIX . "dbtech_usertag_mention AS mention
			LEFT JOIN " . TABLE_PREFIX . "post AS post USING(postid)
			LEFT JOIN " . TABLE_PREFIX . "thread AS thread USING(threadid)			
			WHERE (mention.userid = " . intval($this->profile->userinfo['userid']) . "
				OR mention.mentionedid = " . intval($this->profile->userinfo['userid']) . ")
				AND thread.forumid IN(" . implode(',', USERTAG::forumIds()) . ")
				AND mention.type = 'post'
				AND post.visible = 1

		// Fetch users
		$results_q = $this->registry->db->query_read_slave("
			SELECT 
				post.pagetext AS message,
				post.title AS posttitle,
				thread.title AS threadtitle,
				quote.dateline,
				quote.postid,
				quote.type,
				user.userid,
				user.username,
				user.usergroupid,
				user.infractiongroupid,
				user.displaygroupid,				
				quoted.userid AS quoteduserid,
				quoted.username AS quotedusername,
				quoted.usergroupid AS quotedusergroupid,
				quoted.infractiongroupid AS quotedinfractiongroupid,
				quoted.displaygroupid AS quoteddisplaygroupid			
			FROM " . TABLE_PREFIX . "dbtech_usertag_quote AS quote
			LEFT JOIN " . TABLE_PREFIX . "post AS post ON (post.postid = quote.postid)
			LEFT JOIN " . TABLE_PREFIX . "thread AS thread ON (thread.threadid = post.threadid)
			LEFT JOIN " . TABLE_PREFIX . "user AS user ON (user.userid = quote.userid)
			LEFT JOIN " . TABLE_PREFIX . "user AS quoted ON (quoted.userid = quote.quotedid)
			WHERE (quote.userid = " . intval($this->profile->userinfo['userid']) . "
				OR quote.quotedid = " . intval($this->profile->userinfo['userid']) . ")
				AND thread.forumid IN(" . implode(',', USERTAG::forumIds()) . ")
				AND quote.type = 'post'
				AND post.visible = 1
			ORDER BY $sqlsort $sortorder
			LIMIT $startat, " . $perpage

But displaying a soft deleted post. I had a look in the database and "post" table with "Visible" is always 1. The "thread" table "Visible" is 2 when soft deleted, 1 when active. Perhaps this helps?

 

[Fillip H.]

What about for posts?

 

[mirageboss]

What about for posts?

Thread Table: Droplr • Screenshot on 12.10.2012 at 12.57.16 AM.png
Post Table: Droplr • Screenshot on 12.10.2012 at 12.58.17 AM.png
Thread: Droplr • Screenshot on 12.10.2012 at 12.58.43 AM.png

 

[Fillip H.]

Aha, so the issue in this case is that if the entire thread is soft deleted, it doesn't auto flag posts within as soft deleted.

 

[mirageboss]

Correct yeah if soft deleted the mention still shows. I think it has something to do with the fact ID 2 is used for soft deletions. Not sure tho

 

[mirageboss]

Bump incase my last reply didn't come through

 

[Fillip H.]

I've made further changes to the same file, try now

 

[mirageboss]

Deleted older versions, downloaded from here.

1. Uploaded files.
2. Tested - no luck.

Can provide you a test account access if you want?

 

[Fillip H.]

Sure, FTP and an AdminCP account and I can look into it

 

[mirageboss]

Sent over PM.

Notice: This is a live forum so please be careful.

 

[mirageboss]

Re-PMed ftp info Fillip H.

 

[Fillip H.]

Been resolved on your forum now, and hotfix applied to the release package

 

[mirageboss]

Awesome work Fillip H.! Happy customer! Now seeing its all working, time for me to buy the pro version (is this patched in pro or am I best of waiting?)