Bug userid check

[vB Optimise User]

If the userid is invalid, it should display an error message or redirect to live feed main page.

http://www.dragonbyte-tech.com/livewall.php?u=TEST12345

Regards

 

[Fillip H.]

Currently it does show the live feed main page, I'm confused as to why you're reporting this as a bug when it already does what you want it to do?

 

[vB Optimise User]

I have rewrite rules for livewall.php and allowing anything after u?= is a duplicate content issue.

Don't you think that the links below should display an "invalid userid specified" message?

http://www.dragonbyte-tech.com/livewall.php?u=sdkçfmsdfmsdfmsdşfdmsflsdmfldsmfsdfsdf

http://www.dragonbyte-tech.com/livewall.php?u=3453456476756567567567567567567575

http://www.dragonbyte-tech.com/livewall.php?u=&(/&RTytfoykfrtyrty9r567lrfuy

Note: I checked now and noticed it allows anything after php?, not only ?u... livewall.php?fghöfmhföf

 

[Fillip H.]

I have rewrite rules for livewall.php and allowing anything after u?= is a duplicate content issue.

Don't you think that the links below should display an "invalid userid specified" message?

http://www.dragonbyte-tech.com/livewall.php?u=sdkçfmsdfmsdfmsdşfdmsflsdmfldsmfsdfsdf

http://www.dragonbyte-tech.com/livewall.php?u=3453456476756567567567567567567575

http://www.dragonbyte-tech.com/livewall.php?u=&(/&RTytfoykfrtyrty9r567lrfuy

Note: I checked now and noticed it allows anything after php?, not only ?u... livewall.php?fghöfmhföf

It's impossible to do anything about this unfortunately.

Is duplicate content on an AJAX-only page something to be concerned about?

PS: Adding garbage to the URL parameters on for instance forum.php also works in vBSEO with the default rule set.

 

[vB Optimise User]

Well... What do the URLs below display?

http://www.dragonbyte-tech.com/showthread.php?t=77775

http://www.dragonbyte-tech.com/forumdisplay.php?f=7754

http://www.dragonbyte-tech.com/member.php?u=9999545

I just ask for a similar function for livewall.php?u=

 

[Fillip H.]

While I'm not really comfortable removing a feature from a mod, I've made the change in a hotfix. You can re-download and re-upload /dbtech/livewall/actions/main.php and it will now throw an invalid user error instead of displaying the full wall if you supply a userid that is not in the DB.

 

[vB Optimise User]

While I'm not really comfortable removing a feature from a mod, I've made the change in a hotfix. You can re-download and re-upload /dbtech/livewall/actions/main.php and it will now throw an invalid user error instead of displaying the full wall if you supply a userid that is not in the DB.

I replaced

standard_error(fetch_error('invalid_user_specified'));

with

eval(standard_error(fetch_error('invalidid', $vbphrase['user'], $vbulletin->options['contactuslink'])));

and it sends a 404 header now. Thank you!