Post Negation BUG

[hornstar]

yoyoman or darkwaltz4 can you test if moving a thread from a forum section (with credits enabled) to a forum section (with credits disabled) also negates a users credits properly. I think this was another area that didn't work last time by memory.

 

[yoyoman]

So does the thread award get negated correctly? You mean only the posts deleted as part of that thread arent negated?

Yes, that's exactly what I mean: posts deleted as part of that thread aren't negated.
I haven't checked negation of the thread creation action - I will check now.

 

[yoyoman]

So does the thread award get negated correctly?

Yes, the thread creation action gets negated correctly.
However, as I have mentioned, the posts present in the thread that is being deleted DO NOT GET NEGATED.

yoyoman or darkwaltz4 can you test if moving a thread from a forum section (with credits enabled) to a forum section (with credits disabled) also negates a users credits properly. I think this was another area that didn't work last time by memory.

I tested this just now - NEGATION DOES NOT WORK.
Neither the thread creation action, nor the posts inside the thread are negated, when said thread is transferred from a forum section with credits enabled to a forum section with credits disabled.

 

[Darkwaltz4]

The reason it doesnt negate the posts within a thread when managing the whole thread, is because vb doesnt properly delete the posts within a thread when it deletes those threads so it doesnt activate the hooks.

What it does is just count them and delete them directly from the database, and deduct that count from your postcount. The proper way is to load each post individually, and have the post delete itself (which hits all the hooks for plugins to do stuff with)

I suspect vb did it this way for performance reasons, as it would take ages to process the deletions of threads with many posts, and the hairy cases of deleting multiple such threads

To "fix" this would be to implement this very bad performance decision that vb specifically avoided. It can be done, but i will tell you it will dramatically increase the time it takes to wait for the site to finish deleting a thread. What do you guys think of this tradeoff? Coding that up would take quite some time also (and im busy trying to get to a milestone on a different project).

 

[yoyoman]

For me it's not a really big issue - I can tell the moderators to first delete all the posts in a thread and then delete the tread itself.
What about the negation of the thread and the posts in a thread, when a whole thread is moved? Is it possible to fix/partially fix that?

 

[Darkwaltz4]

it is a similar situation (vb faking mass operations vs using the objects that run the hooks)

 

[hornstar]

The moving thread is a huge issue for myself.

As we are all the time moving threads into a trash section.

 

[Darkwaltz4]

hornstar can you start a new bug report here for thread move/delete? i can keep track of that separately

 

[hornstar]

hornstar can you start a new bug report here for thread move/delete? i can keep track of that separately

I could, but this thread is progressing so nicely and kinda the same same. It's all to do with the negation.

But I understand you really want to get back on with your other task.

 

[Ozzy47]

hornstar he wants it in a seperate thread so when he looks through the bug reports, and suggestions they are all seperate, this way something don't get passed over

 

[Cosmic]

^ That =)

We have a system that tracks the status, response times, progress etc of each bug. If there are a couple in one thread it's hard for us to tell if there is still an unresolved issue in the thread - if one issue is solved but the other isn't the person either marks it as unsolved which will negatively affect the tracking of their resolution times, or they mark it as solved which means they are likely to overlook it later.

Sorry for any inconvenience!

Cosmic

 

[hornstar]

Anyone is welcome to post the bug if you like. You all know as much as me.