Bug Cannot remove password from Album

[Lee Harrington]

In the album creation menu, the Password option and the one above it autocompletes. This adds a password to the album if your not paying attention. Attempting to remove the password by clicking on edit on the album is unsuccessful. I am an administrator, i should be able to remove other users passwords i believe.

 

[Dylan]

I'll look into it. The plan was the box would be empty if there was no password. If there was a password there would be a predefined text that was entered in the field on edit. If the text wasn't changed it would not do anything to the password in the db. If the box was cleared it would clear the password and if the text was changed it would change the password in the db. I'll go through it again and see if I can replicate the problem.

 

[Dylan]

I also noticed, your account is still set as awaiting email authentication. I reset the auth email so it'll updated when you verify. It might cause some problems if you are still in that group on getting notifications and other stuff.

 

[Dylan]

I found the problem. I'll fix it in the next release.

If you want to manually fix it for now

Open dbtech/gallery/actions/doeditalbum.php

Find

if (($vbulletin->GPC['password']) && ($vbulletin->GPC['password'] != '99999999'))
{
    $passwordsql = md5($vbulletin->GPC['password']);
} else {
    $passwordsql = $album_data['password'];
}

replace it with

if (($vbulletin->GPC['password']) && ($vbulletin->GPC['password'] != '99999999'))
{
    $passwordsql = md5($vbulletin->GPC['password']);
} elseif (!$vbulletin->GPC['password']) {
    $passwordsql = '';
} else {
    $passwordsql = $album_data['password'];
}

Now if you edit the album and clear the password field and save it, it will clear out the password in the db.

 

[Lee Harrington]

Screen shot of fields autofilling.

 

[Dylan]

Is that after you made the code change? The only time it should prefill is if there is an existing password. It prefills with dummie data since the password is encrypted. But it shouldn't fill if there is no password.

 

[Lee Harrington]

yeah, thats with no password, and code changes. It does it with every album I try and create

 

[Dylan]

Hmm, I can't replicate it locally. Can I get an account with access to the gallery?

 

[Lee Harrington]

Done, check PM. You have supermod access.

 

[Dylan]

Weird, it's not doing it locally, but it's using the stored login info for the forum, I'll fix it and come out with a new release shortly

 

[Lee Harrington]

Much thanks man. Your work is appreciated.

 

[Dylan]

I just uploaded 1.0.4 that should fix it. Let me know if it does and I'll post a release notice

 

[Lee Harrington]

UPgraded to 1.04 and still autocompleting in album creation.

 

[bszopi]

Is your browser perhaps autocompleting it? Try a different browser perhaps, or maybe flush your cache and see if it still does it.

Brad via Tapatalk

 

[Dylan]

Did you install the xml file? I looked and it's still using the old template

EDIT:
Ah, I found a problem with the package. Can you redownload it and reinstall it? Sorry about that.

 

[bszopi]

That's what happens when you start getting older. You start finding problems with your package...

 

[Dylan]

That's what happens when you start getting older. You start finding problems with your package...

Like you are that much younger

Let me know if the new package works for you Lee