Bug Exclusivity not working properly. It won’t let me save changes.

[Fillip H.]

That's theoretically possible, yeah. Sadly there's no way around that without replacing vBulletin's notification system with one of our own - a task we may just attempt in the future if we can find enough reason to do so in other mods (Cosmic feel free to chime in if you can see this having a place - I literally thought of it just now though xD).

Back on topic: I believe I have fixed it; the problem was really in the display only - exclusivity WAS actually changed, just not reflected in the display due to the way PHP handles bitfields.

You'd check a bitfield like so:

if ($button['exclusivity'] & $otherbutton['bitfield'])

In plain English: If the button's exclusivity bit value contains the bit value of the other button, it's exclusive.

But problems arise if either $button['exclusivity'] or $otherbutton['bitfield'] is a string.

The following will return true

if ("2" == 2)

As will this

if (2 & 2)

But the following will not

if ("2" & 2)

However, this will

if ((int)"2" & 2)

Due to a technique called "type casting". It will take the string "2" and convert that into its integer value.

I've applied that type casting to every single instance of bitfield usage in the entire Thanks mod, so I believe that should take care of it.


Sorry for the rather long-winded explanation, but due to the runaround I've been giving you I felt I owed you the full explanation as to why I couldn't reproduce it before and how I fixed it

 

[s3ponline]

Do I need to redownload it?

 

[s3ponline]

Nice! Everything works just as intended now.

Hahaha, now I don’t have to feel crazy about not understanding why the hell I couldn’t make thing exclusive

 

[rootsxrocks]

Can you try ensuring any vbseo caching options are set to off?

sorry I have just returned, its been a busy spring. I do not have Vb SEO on my site. I am having sporadic reports that members can not unlike and a few have been able to bypass the exclusivity and press more than one selection. Also it does not appear that the hide the post is working at all, but that could be my confusion about the way to enter the values.

 

[Fillip H.]

Try re-downloading and re-uploading again, we've added some fixes about 2 weeks ago that might fix this

 

[rootsxrocks]

mine all work fine, however if someone is quick they can double push and then will not be able to undo it.