Bug Delete Image issues

[GoodApples]

The check box for delete is misplaced and can not delete images.

do=edit_image

 

[GgAcE]

Also confirmed for vbulletin 4.1

 

[Dylan]

The checkbox was forced to the far right on purpose. I didn't want it checked by accident, wanted it to be a conscious decision.
I'll check why it's not deleting though.

 

[Dylan]

Open
dbtech/gallery/actions/doeditimage.php

Find

DBTECH_GALLERY::delete_item($vbulletin->GPC['imageid'], 'image');

Replace with

DBTECH_GALLERY::delete_item($vbulletin->GPC['imageid'], 'images');

That should do it

 

[GoodApples]

The checkbox was forced to the far right on purpose. I didn't want it checked by accident, wanted it to be a conscious decision.
I'll check why it's not deleting though.

I think it looks odd but that's just me.
How about moving the word delete to the far right as well and maybe change it to delete image

or another option tucking the check box right under delete on the left and moving save to the right...we can make this better.

Yes, this indeed deleted the image...mmm...is there some kind of cron job to clean up the images from the server?

 

[Dylan]

Hmm, what about removing the checkbox and doing a Delete Image button on the right side, same level as the save? That might be better actually. I can do a popup are you sure you want to delete this? and then do it through ajax.

When you delete the image it removes all the image files from the server. Or it should, let me know if it's leaving any behind.

 

[GoodApples]

Yeah, that would be better.
Yes, the images are left behind.


Oh this just convinced me about that other thread...follow the vBulletin default layout. the Edit Picture there works.

 

[GoodApples]

When you delete the image it removes all the image files from the server. Or it should, let me know if it's leaving any behind.

Yes, still leaving them on the server. v1.0.0 b

 

[Dylan]

Open dbtech/gallery/includes/class_core.php

On about line 366 you'll see

            if (file_exists($pic_thumb_name) && !is_dir($pic_thumb_name))
            {
                @unlink($pic_thumb_name);
            }

            if (file_exists($pic_full_name) && !is_dir($pic_full_name))
            {
                @unlink($pic_full_name);
            }

            if (file_exists($pic_wm_name) && !is_dir($pic_wm_name))
            {
                @unlink($pic_wm_name);
            }

Change it to

            if (file_exists($pic_thumb_name) && !is_dir($pic_thumb_name))
            {
                unlink($pic_thumb_name);
            }

            if (file_exists($pic_full_name) && !is_dir($pic_full_name))
            {
                unlink($pic_full_name);
            }

            if (file_exists($pic_wm_name) && !is_dir($pic_wm_name))
            {
                unlink($pic_wm_name);
            }

Then try and delete an image. It should give you an error. Let me know what it is

 

[GoodApples]

No error message on both New Style and Default Style.
Images delete but the images remain stored on the server.

 

[Dylan]

hmm, could I get ftp access and an account that can upload images? Sounds like it's just skipping over the image delete code for some reason.

 

[GoodApples]

Sent

 

[Dylan]

Thanks for that, I got it worked out, it's deleting them now

 

[GoodApples]

Okay, I still see in the upload file...your image which is highlighted?

 

[Dylan]

Yeah, I left a couple old ones there, so when I get the ACP option to clean up orphaned images you'll have some to test with
But if you create a new image and delete it, the files should go away now

 

[GoodApples]

Confirmed new images went away.
Thanks Dylan