Bug Pm notification

[Ozzy47]

When a new member signs up and you have Welcome Private Message set in vBulletin it used to show in shout that user has a pm, but I don't see that happening anymore.

 

[Fillip H.]

I have been unable to confirm this in my v5.4.3 build, so hopefully it's been fixed by something else I did xD

I'll leave this up as Awaiting Feedback for when you've had a chance to test it

FYI you can force an user registration notification by adding a new user via the AdminCP, it works just the same

 

[Ozzy47]

Looks like ya got it my friend, great job once again!!

 

[Ozzy47]

Well I spoke too soon, if you add a user in acp it shows the pm message in shout, but if a user signs up to the forum, it don't show the pm message, and I know the forum pm was sent, I verified it in phpmyadmin.

 

[Fillip H.]

I just tested it on local and I saw the shout message just fine.

I'll try signing up to your forums again and see what happens.

 

[Ozzy47]

ok cool

 

[Fillip H.]

Before I test this, could you please re-download and re-upload the files? Your forum appears to be affected by a bug I fixed a few hours ago but couldn't explain why I couldn't reproduce.

Your shoutbox doesn't refresh on inserting a new shout / editing a shout / deleting a shout, only after a minute.

 

[Ozzy47]

Ok all loaded and xml imported

 

[Fillip H.]

Hmm...

Does your "Welcome PM User" have permission to shout? As in, is the person whose username you have added part of a usergroup that has permissions to shout in the shoutbox?

 

[Ozzy47]

Yes the usergroup can shout, and pm shout and also can forum pm, I again see the forum pm was sent to Fillip H.Test1 in phpmyadmin

 

[Fillip H.]

Yeah I saw the PM in my inbox too...

*load up old FTP info like a boss*

I got dis. *cracks knuckles*

 

[Fillip H.]

Solved

 

[Ozzy47]

I saw that bro, was it site specific or is it another hot fix?

 

[Fillip H.]

Another hotfix. I didn't take into consideration that the permissions I used to check would be from the visiting user, not the user who actually submitted the shout.

I also added support for "automated shouts" - notification-based shouts will in the future ignore many permission checks (they ARE automated, after all) which should prevent this from happening again

 

[Ozzy47]

Well excellent job, glad ya got it sorted!