Bug latest thread view link incorrect

[Captive Reefs]

I just noticed the link for Latest thread is trying to go to a blog instead of a forum thread.

for example .../showthread.php?blogid=17183

 

[Fillip H.]

Whoops, copypasting SNAFU there
Patched on your site, thanks

 

[Captive Reefs]

Although I just got into the phpmyadmin and changed the link from blogid to threadid and it is working now....

or maybe you did it?

 

[Fillip H.]

I did it

 

[Captive Reefs]

If I can ask...where is the setting to change that type of stuff. I see it in phpmyadmin in the postbittabs_view table. Is that the best place to change it or no?

 

[Fillip H.]

The values in that table will be overwritten by the HTML code that's present in all the mods that hook into this mod, that's why it's not editable.

This was done to ensure that fixes like these are properly probagated to all customers when they download the fix

 

[Captive Reefs]

Well now that its all working...I just realized that it doesn't check for the latest thread that who ever is looking at it has permissions to view. It ends up showing the title to everyone regardless of permissions. Can this be changed as a feature request?

EDIT:

The values in that table will be overwritten by the HTML code that's present in all the mods that hook into this mod, that's why it's not editable.

This was done to ensure that fixes like these are properly probagated to all customers when they download the fix

So the code is in the pluggin system or the modification's php files themselves?

 

[Fillip H.]

PHP files.

Doing permission checks is sadly not possible due to performance reasons - it would mean one query per post in your postbit to get the last accessible thread

That's why we have it disabled here on DBTech - we simply added the feature because some forums may not care about others viewing thread titles they can't access.

 

[Captive Reefs]

Yeah...I can see that. I guess I reached the same point you guys did with that "view". You never know what a mod might title a thread about a problem member thinking it is in private. I think it is best to leave that one disabled too.

I guess I'll have to make a similar decision about the last post view. It isn't quite as big of a deal since it only shows the time.

 

[Fillip H.]

Yea that too might be a problematic view if some staffers or members prefer to post only in private forums, others going "OMFG WHY YOU IGNORE ME!!!" etc