Bug PM Link still unclickable

[Em Kay]

Looks better than it did before...maybe removing the () will correct the issue or adding a space ( url ) before and after the link?

 

[Mokonzi]

Can you PM me a list of all the mods you have installed?

Your suggestion is good, but probably won't make much difference. We use two phrases for notices. One that goes out in emails which uses HTML, the other for PMs which uses BBCodes, including the URL tags.

If the mod was grabbing the HTML phrase, you'd see the HTML unparsed in the PM. If it wasn't parsing the BBCode phrase it would show you the BBCode tags. The fact there aren't there suggests something else is altering the message before it sees the light of day...

The space in the link is odd as well. It doesn't exist in the phrase.

Can you also paste me exactly what you have for these phrases in your system:

dbtech_classifieds_listing_pm_bought_1_message and dbtech_classifieds_listing_pm_data_1_x

I have noticed the maths doesn't seem to add up though... Better check that one out in the code... :?

 

[Em Kay]

Can you also paste me exactly what you have for these phrases in your system:

dbtech_classifieds_listing_pm_bought_1_message and dbtech_classifieds_listing_pm_data_1_x

I have noticed the maths doesn't seem to add up though... Better check that one out in the code... :?

 

[Mokonzi]

Yeah, they are as they should be. Something must be stripping out the link. :?

 

[Em Kay]

Yeah, they are as they should be. Something must be stripping out the link. :?

The link works in Watched Items PMs but links back to a blank page

Doesnt work in Buy it Now PMs

Works in Wanted PMs but links back to a blank page

Works in Auction PMs but links back to a blank page...


so it seems the link just does work in the buy it now pms

 

[Mokonzi]

I'll have another look at the code and run some more tests to see if I can identify the issue. You run your classifieds on a subfolder, right?

 

[Em Kay]

I'll have another look at the code and run some more tests to see if I can identify the issue. You run your classifieds on a subfolder, right?

I assuming so, but I will ask just to be sure!

 

[Mokonzi]

I've checked and tested this and I've not been able to reproduce this still. I'll ask Fillip H. if he has any ideas why we might get this issue. :?

 

[Em Kay]

I've checked and tested this and I've not been able to reproduce this still. I'll ask Fillip H. if he has any ideas why we might get this issue. :?

sounds like a plan!

 

[Em Kay]

Just asked the forum owner about the plugin, its a custom notification code so I dont know anything about it. We're going for a site overhaul in the next couple weeks so we'll worry about fixing it then

 

[Mokonzi]

Em, can you test something for me?

dbtech_classifieds_listing_pm_bought_1_message and dbtech_classifieds_listing_pm_data_1_x

Can you replace the part of the URL in that phrase that is

viewlistng

With:

viewlisting

Let me know if that fixes your issue.

 

[Darkside]

Em, can you test something for me?

dbtech_classifieds_listing_pm_bought_1_message and dbtech_classifieds_listing_pm_data_1_x

Can you replace the part of the URL in that phrase that is

viewlistng

With:

viewlisting

Let me know if that fixes your issue.

in Version 1.1.9 is the same error.

replace in /dbtech/classifields/includes/functions_listings.php the following lines

// Buyer Email Data
$subject = construct_phrase($vbphrase['dbtech_classifieds_listing_bought_1_from_x'], $luser['username']);
$body = construct_phrase($vbphrase['dbtech_classifieds_listing_bought_1_message'], $domainurl, $ouser['username'], $listing['title'], $listing['listingid'], $luser['username'], implode("\n", $body_data), count($listing['offers']), CLASSIFIEDS::$cache['currency'][$listing['currencyid']]['denomination'], $totalprice);
$pmbody = construct_phrase($vbphrase['dbtech_classifieds_listing_pm_bought_1_message'], $domainurl, $ouser['username'], $listing['title'], $listing['listingid'], $luser['username'], implode("\n", $body_data), count($listing['offers']), CLASSIFIEDS::$cache['currency'][$listing['currencyid']]['denomination'], $totalprice);

with these lines :

// Buyer Email Data
$subject = construct_phrase($vbphrase['dbtech_classifieds_listing_bought_1_from_x'], $luser['username']);
// $body = construct_phrase($vbphrase['dbtech_classifieds_listing_bought_1_message'], $domainurl, $ouser['username'], $listing['title'], $listing['listingid'], $luser['username'], implode("\n", $body_data), count($listing['offers']), CLASSIFIEDS::$cache['currency'][$listing['currencyid']]['denomination'], $totalprice);
// $pmbody = construct_phrase($vbphrase['dbtech_classifieds_listing_pm_bought_1_message'], $domainurl, $ouser['username'], $listing['title'], $listing['listingid'], $luser['username'], implode("\n", $body_data), count($listing['offers']), CLASSIFIEDS::$cache['currency'][$listing['currencyid']]['denomination'], $totalprice);
// Test Nachricht
$body = construct_phrase($vbphrase['dbtech_classifieds_listing_bought_1_message'], $domainurl, $ouser['username'], $listing['title'], $listing['listingid'], $luser['username'], implode("\n", $body_data), count($listing['offers']), CLASSIFIEDS::$cache['currency'][$listing['currencyid']]['denomination'], $totalprice);
$pmbody = construct_phrase($vbphrase['dbtech_classifieds_listing_pm_bought_1_message'], $domainurl, $ouser['username'], $listing['title'], $listing['listingid'], $luser['username'], implode("\n", $body_datapm), count($listing['offers']), CLASSIFIEDS::$cache['currency'][$listing['currencyid']]['denomination'], $totalprice);

that worked for me.

 

[Darkside]

The link works in Watched Items PMs but links back to a blank page

Doesnt work in Buy it Now PMs

Works in Wanted PMs but links back to a blank page

Works in Auction PMs but links back to a blank page...


so it seems the link just does work in the buy it now pms

I have the same in V 1.1.9

change the following line in /dbtech/classifieds/includes/functions_listings.php

$domainurl = $vbulletin->options['bburl'] ;

in this :

$domainurl = $vbulletin->options['bburl'] . '/dbtclassifieds.php';

worked for me

 

[Mokonzi]

Nicely isolated. I've applied the first fix entirely to 1.1.9, the second I've tweaked for those that use a different file names.

Thanks for your help in spotting this Darkside.

 

[Darkside]

Nicely isolated. I've applied the first fix entirely to 1.1.9, the second I've tweaked for those that use a different file names.

Thanks for your help in spotting this Darkside.

now there is a nother mistake :


change in /dbtech/classifields/includes/functions_listings.php the following lines

// Buyer Email Data
$subject = construct_phrase($vbphrase['dbtech_classifieds_listing_bought_1_from_x'], $luser['username']);
$body = construct_phrase($vbphrase['dbtech_classifieds_listing_bought_1_message'], $domainurl, $ouser['username'], $listing['title'], $listing['listingid'], $luser['username'], implode'(<br />', $body_data), count($listing['offers']), CLASSIFIEDS::$cache['currency'][$listing['currencyid']]['denomination'], $totalprice);
$pmbody = construct_phrase($vbphrase['dbtech_classifieds_listing_pm_bought_1_message'], $domainurl, $ouser['username'], $listing['title'], $listing['listingid'], $luser['username'], implode('<br />', $body_datapm), count($listing['offers']), CLASSIFIEDS::$cache['currency'][$listing['currencyid']]['denomination'], $totalprice);
if ($sendemail) vbmail($ouser['email'], $subject, $body, true, ($vbulletin->options['dbtech_classifieds_email_address'] ? $vbulletin->options['dbtech_classifieds_email_address'] : $vbulletin->options['webmasteremail']), '', $vbulletin->options['dbtech_classifieds_email_sender']);
if ($sendpm) CLASSIFIEDS::sendPM($ouser, $subject, $pmbody, 'dbtech_classifieds_email_sender');

in this

// Buyer Email Data
$subject = construct_phrase($vbphrase['dbtech_classifieds_listing_bought_1_from_x'], $luser['username']);
$body = construct_phrase($vbphrase['dbtech_classifieds_listing_bought_1_message'], $domainurl, $ouser['username'], $listing['title'], $listing['listingid'], $luser['username'], implode("\n", $body_data), count($listing['offers']), CLASSIFIEDS::$cache['currency'][$listing['currencyid']]['denomination'], $totalprice);
$pmbody = construct_phrase($vbphrase['dbtech_classifieds_listing_pm_bought_1_message'], $domainurl, $ouser['username'], $listing['title'], $listing['listingid'], $luser['username'], implode("\n", $body_datapm), count($listing['offers']), CLASSIFIEDS::$cache['currency'][$listing['currencyid']]['denomination'], $totalprice);

you just have to change the red sign

after the change it will look like as shown in the picture

 

[Mokonzi]

now there is a nother mistake :
View attachment 6318

change in /dbtech/classifields/includes/functions_listings.php the following lines



in this




you just have to change the red sign

after the change it will look like as shown in the picture

View attachment 6317

Thanks for highlighting that. I'm putting together a new update for v1 with these and some other fixes.