Bug vBShop Member shops

[Jester]

A few issues with member shops:

1. Feedback reminders do not go out automatically, I had others buy things and purposely not leave feedback to ensure it wasn't just me.
2. When deleting a feedback (there’s no edit), the overall percentage does not change. An example, if someone leaves negative feedback and we remove it, the negative percent and star ratings stay the same. <---- Important
3. It was reported to me that if you make like four custom fields and set them as mandatory, only fields 2,3,and 4 show to the customer. Even if you just fill out one custom field, the customer is not able to configure and enter text. Configuring just brings you to a blank page with a save button. <---- Important

 

[Fillip H.]

1. In the Gold version, I added yet more debug data to the cron job - is there anything in the log at all?

2. I'll be testing this and hopefully have a hotfix by tomorrow at the latest

3. Is this if an Administrator configures the Custom Item, or a user in their personal shop?

 

[Jester]

1. In the Gold version, I added yet more debug data to the cron job - is there anything in the log at all?

2. I'll be testing this and hopefully have a hotfix by tomorrow at the latest

3. Is this if an Administrator configures the Custom Item, or a user in their personal shop?

1. I will check
2. OK
3. Member Shops, member configured.

 

[Fillip H.]

3. Does it also happen if the item is in a System owned shop (i.e. no owner) and the item is configured by an admin?

 

[Jester]

3. Does it also happen if the item is in a System owned shop (i.e. no owner) and the item is configured by an admin?

No, it does not happen. As the system admin, I added an item and required configuration of two custom fields. The notification I received contained both filled out fields. I then added the identically configured item as a member. When I went to configure as the customer, only the second field was presented to me for input.

 

[Fillip H.]

2. When deleting a feedback (there’s no edit), the overall percentage does not change. An example, if someone leaves negative feedback and we remove it, the negative percent and star ratings stay the same. <---- Important

I believe this has now been fixed, I tested deleting feedback and the counters updated correctly.

3. It was reported to me that if you make like four custom fields and set them as mandatory, only fields 2,3,and 4 show to the customer. Even if you just fill out one custom field, the customer is not able to configure and enter text. Configuring just brings you to a blank page with a save button. <---- Important

This has now been fixed. Unfortunately, you will need to re-configure all custom items configured in the front-end, as it was a bug in which the front-end interface displayed six form fields, instead of five, and starting their numbering sequence from 0, instead of 1.


These have been hotfixed into v3.1.0

 

[Jester]

I believe this has now been fixed, I tested deleting feedback and the counters updated correctly.

This has now been fixed. Unfortunately, you will need to re-configure all custom items configured in the front-end, as it was a bug in which the front-end interface displayed six form fields, instead of five, and starting their numbering sequence from 0, instead of 1.


These have been hotfixed into v3.1.0

Perfect. Rating recalc and configuration fields are now working. Thank you.

My staff brought up two potential issues.

1. Members can purchase items from themselves and give feedback to themselves. This renders feedback totally worthless.
2. Members with shops can link to any size image for their shops. This breaks the page. Is there a way to limit the image dimensions?

 

[Fillip H.]

1. I've patched this in the latest version

2. You should edit dbtech_vbshop_shop_shopbit and add either width or height attributes to the <img> tag there. Setting only one dimension will allow the image to scale properly.

 

[Jester]

1. I've patched this in the latest version

2. You should edit dbtech_vbshop_shop_shopbit and add either width or height attributes to the <img> tag there. Setting only one dimension will allow the image to scale properly.

1. Will that be in 3.1.0 up for re-download or 3.1.1 in the future?
2. Thank you, that worked.

 

[Fillip H.]

It's up in 3.1.0.

 

[Fillip H.]

Update: I've applied an additional hotfix to /dbtech/vbshop_pro/cron/feedback.php to reflect that notices should not be sent for transactions in shops that have feedback globally disabled.

There's currently no way to see at a glance what shops have missing feedback, this should be posted as a separate feature request to ensure it gets noticed


Also, a quick reminder that I'm still waiting to hear back whether there's any additional debug information in the cron job logs that would indicate why automatic feedback notices aren't being sent

 

[Jester]

Update: I've applied an additional hotfix to /dbtech/vbshop_pro/cron/feedback.php to reflect that notices should not be sent for transactions in shops that have feedback globally disabled.

There's currently no way to see at a glance what shops have missing feedback, this should be posted as a separate feature request to ensure it gets noticed


Also, a quick reminder that I'm still waiting to hear back whether there's any additional debug information in the cron job logs that would indicate why automatic feedback notices aren't being sent

Thanks, I will apply the patch. Also, even though it's scheduled at 2:01 am, there are no entries in the log. The only time it logs anything is when I manually run it.

Maybe it's just not running on it's own.

 

[Fillip H.]

That's interesting, it could be a symptom of a PHP error not evident when running it via the AdminCP (the front-end and admincp are initialised vastly different - ACP has more in common with vB3's front-end).

Do you have error logging to file enabled in php.ini? If not, you may have entries in your server's error_log. On WHM/CentOS servers it's usually located in /usr/local/apache/logs/error_log, though YMMV.

 

[Jester]

That's interesting, it could be a symptom of a PHP error not evident when running it via the AdminCP (the front-end and admincp are initialised vastly different - ACP has more in common with vB3's front-end).

Do you have error logging to file enabled in php.ini? If not, you may have entries in your server's error_log. On WHM/CentOS servers it's usually located in /usr/local/apache/logs/error_log, though YMMV.

Errors pertaining to vbshop from my php-fpm error log:

[24-Apr-2013 00:03:07] WARNING: [pool www] child 23188, script '/var/www/htdocs/wizard/forums/vbshop.php' (request: "POST /forums/vbshop.php") executing too slow (90.491593 sec), logging
[23-Apr-2013 22:15:07] WARNING: [pool www] child 14223, script '/var/www/htdocs/wizard/forums/vbshop.php' (request: "POST /forums/vbshop.php") executing too slow (111.999140 sec), logging

I found no errors pertaining to cron/feedback.php in my www-error log.

I wish I had more to give you. I will enable logging in my php.ini and see how it looks tomorrow.

 

[Jester]

Good news. The cron ran on it's own when I set it to 13:55 to test with. No php errors.

Contents of my sched task log:

117929	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117928	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117927	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117926	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117925	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117924	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117923	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117922	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117921	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117920	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117919	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117918	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117917	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117916	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117915	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117914	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117913	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117912	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117911	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117910	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117909	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117908	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117907	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117906	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117905	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117904	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117903	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117902	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117901	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117900	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117899	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117898	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117897	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117896	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117895	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117894	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117893	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117892	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117891	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117890	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117889	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117888	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117887	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117886	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117885	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117884	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117883	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117882	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117881	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117880	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117879	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117878	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117877	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117876	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117875	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117874	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117873	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117872	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117871	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117870	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117869	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117868	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.
117867	(Pro) DragonByte Tech: vBShop - Send Feedback	13:55, 24th Apr 2013	Reminder Error: Shop ID 1 cannot receive feedback.

 

[Jester]

So I purchased something from a member shop. Did not leave feedback. Reset the sched task to run at 14:10. Task ran, but no feedback reminder sent. Does it need to wait a certain period of time before "no feedback" translates into a reminder or does only the cron control it?

 

[Fillip H.]

24 hours, you can change that by editing the following part of the feedback.php file:

AND purchase.dateline <= (UNIX_TIMESTAMP() - 86400)

Change 86400 to the number of seconds after purchase a feedback reminder should be sent.

 

[Jester]

24 hours, you can change that by editing the following part of the feedback.php file:

AND purchase.dateline <= (UNIX_TIMESTAMP() - 86400)

Change 86400 to the number of seconds after purchase a feedback reminder should be sent.

Reminders do not go out when automatically scheduled still. I can find no errors. The task does run.

I have another issue with the shop. We currently have 12-15 member shops set up for testing. I would like the main shop, mine, to show first..... so I set the display order in the back end. The order sticks on the front end for a period of time, then it mixes them all up. When this happens, members complain that they cannot enter the main shop once they find it. They say they click and click and it never loads. At that point I have to renumber all the shops in the back end, and that fixes it until it decides to jumble them all up again. Seems to be a major issue.

Is there a way I can pull the main shop out of the mix so it doesn't get mixed in with the rest?

 

[Fillip H.]

Are you using some 3rd party script that uses a bridge to connect two systems together (such as Wordpress & vBulletin or a Wiki and vBulletin) or something? Your forum has strange, unexplained issues in every single modification, issues that - to the best of my abilities - should be physically impossible.

- There's no point of failure in the Cron job that doesn't produce some form of log.
- There's no code anywhere that changes the display order of shops.
- The code to access a shop is dynamic, meaning if you can access one shop, you can access all others.

Literally all your issues have - again, to the best of my abilities - no way they can possibly be happening, yet they are.

I've come across all sorts of modifications except for bridge modifications, so those are the only possible things I can think of that could poison the vBulletin environment to the point where random things that aren't coded anywhere still happen.

If not, then I really, really need you to set up another domain on your server and copy the files/database to this new domain. I remember you told me how much effort that would be, but it's going to take several hours of debugging to investigate even one of these issues - never mind all of them - and during this time your forum will not be operational. Plus, there's a real chance that since I will essentially be throwing darts in the dark I will accidentally break something else - I'm not really willing to take that risk on a live site.

 

[Jester]

Are you using some 3rd party script that uses a bridge to connect two systems together (such as Wordpress & vBulletin or a Wiki and vBulletin) or something? Your forum has strange, unexplained issues in every single modification, issues that - to the best of my abilities - should be physically impossible.

Yes, vBSSO. However, the still happening disappearance of credits pre-dates it's installation.

- There's no point of failure in the Cron job that doesn't produce some form of log.

Reminders go out when I manually run it. You mentioned different permissions..... could this still be the case?

- There's no code anywhere that changes the display order of shops.

Agreed, yet the .js appears to "break". The only caching I am using is vBOptimize/memcache.

- The code to access a shop is dynamic, meaning if you can access one shop, you can access all others.

The issue is that no shops can be accessed by the members who complain. Naturally, (to further complicate it), I have no troubles even when they are jumbled.

Literally all your issues have - again, to the best of my abilities - no way they can possibly be happening, yet they are.

I've come across all sorts of modifications except for bridge modifications, so those are the only possible things I can think of that could poison the vBulletin environment to the point where random things that aren't coded anywhere still happen.

The author of vBSSO is quite responsive and I'm certain would be willing to answer any questions I pose. The trouble is I wouldn't know what to ask.

If not, then I really, really need you to set up another domain on your server and copy the files/database to this new domain. I remember you told me how much effort that would be, but it's going to take several hours of debugging to investigate even one of these issues - never mind all of them - and during this time your forum will not be operational. Plus, there's a real chance that since I will essentially be throwing darts in the dark I will accidentally break something else - I'm not really willing to take that risk on a live site.

I understand, but duplicating this site would only be possible if I leased and set up another pair of servers due to storage shortfalls. It's a big site. The servers have also been professionally tuned by Eva2000 and I'm not about to mess with his very expensive work by adding another big site to the mix.

The problems are frustrating, I'm with ya there. I have zero issues with anything else on the site.

Don't sweat it, I'll learn to live with it all. Thanks for your time and patience through all of this.