Pagination

[Trekkan]

On my forums, if you visit:

http://www.darkhandofvalor.com/vbac...20&sortorder=desc&sorttype=avgpercent&page=44

You can see that it says there are 56 pages of data, but the last 12 pages are empty. I'm guessing these are the people with zero activity and the pagination just isn't accounting for that?

 

[Fillip H.]

Hmm that's peculiar.
I'll take a look in a minute, I'll have this solved soon enough

 

[Fillip H.]

This has now been fixed.
The problem was the fact that the pagination generation didn't take into account banned users, but the actual list did.

You've banned like 150 people, haven't you xD


Oh, and also: If you got a database error email about "user.userid" something, that was my fault, sorry

 

[Trekkan]

This has now been fixed.
The problem was the fact that the pagination generation didn't take into account banned users, but the actual list did.

You've banned like 150 people, haven't you xD


Oh, and also: If you got a database error email about "user.userid" something, that was my fault, sorry

Heh yeah, I've banned a few. Mostly spammers, I just need to go through and delete a lot of accounts to clean that up. Thanks for the reminder.

Also, yeah, I've been seeing that error, wasn't sure where it was coming from since the referring URLs weren't vbshout pages. Good to know and I'll stop worrying about it until the next release. =)

 

[Fillip H.]

Well it should only have happened briefly as I made a small mistake when I implemented the fix on your forum.
How many emails did you get?

 

[Trekkan]

In looking for that error, I just found this one from about 5 hours ago in my email:

Database error in vBulletin 4.0.2:

Invalid SQL:

SELECT COUNT(userid) AS totalusers
FROM dhv_user
LEFT JOIN dhv_usergroup AS usergroup ON (usergroup.usergroupid = user.usergroupid)
WHERE (usergroup.genericoptions & 32);

MySQL Error : Unknown column 'user.usergroupid' in 'on clause'
Error Number : 1054
Request Date : Tuesday, March 2nd 2010 @ 06:11:53 AM
Error Date : Tuesday, March 2nd 2010 @ 06:11:53 AM
Script : http://www.darkhandofvalor.com/vbac...20&sortorder=desc&sorttype=avgpercent&page=44
Referrer : http://www.dragonbyte-tech.com/showthread.php?p=217
IP Address : XXXXXXXXXXX
Username : TempUser
Classname : vB_Database
MySQL Version :

I assume that's the one you were talking about?

Because this error is what I was talking about:

Invalid SQL:

SELECT userid,

FROM dhv_user AS user
ORDER BY userid;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'FROM dhv_user AS user
ORDER BY userid' at line 3
Error Number : 1064
Request Date : Tuesday, March 2nd 2010 @ 12:13:25 AM
Error Date : Tuesday, March 2nd 2010 @ 12:13:26 AM
Script : http://www.darkhandofvalor.com/cron.php?rand=1267510405
Referrer : http://www.darkhandofvalor.com/forum.php
IP Address : XXXXXXXXXXXX
Username : Unregistered
Classname : vB_Database
MySQL Version :

 

[Fillip H.]

Oh dear, I didn't know about that latter one... I've just patched your site so you should no longer be receiving this error

 

[Trekkan]

Sweet! Thank you!