Bug Download Delay Causing Occasional SQL error for Unregistered Users

[Webbstre]

Hi again! I pushed 2.01 to my live site today and it went great! ... except for a couple errors. After I deleted the listings.php file that caused one set of errors I ended up with just a couple of new errors involving unregistered users and the download delay producing an advertisement. Here are two different versions:

Database error in vBulletin 4.2.0:

Invalid SQL:

### INSERT QUERY GENERATED BY fetch_query_sql() ###
INSERT INTO vb4_dbtech_downloads_delay
(`userid`, `fileid`, `dateline`)
VALUES
('0', '1790', '1364032640');

MySQL Error : Duplicate entry '0-1790' for key 'PRIMARY'
Error Number : 1062
Request Date : Saturday, March 23rd 2013 @ 02:57:10 AM
Error Date : Saturday, March 23rd 2013 @ 02:57:10 AM
Script : http://www.runicgamesfansite.com/vbdownloads.php?do=file&fileid=1790&v=53513061557895.9
Referrer : http://www.runicgamesfansite.com/vbdownloads.php?do=file&fileid=1790
IP Address : 59.46.59.22
Username : Unregistered
Classname : vB_Database
MySQL Version :

Database error in vBulletin 4.2.0:

Invalid SQL:

### INSERT QUERY GENERATED BY fetch_query_sql() ###
INSERT INTO vb4_dbtech_downloads_delay
(`userid`, `fileid`, `dateline`)
VALUES
('0', '1784', '1364029432');

MySQL Error : Duplicate entry '0-1784' for key 'PRIMARY'
Error Number : 1062
Request Date : Saturday, March 23rd 2013 @ 02:03:42 AM
Error Date : Saturday, March 23rd 2013 @ 02:03:43 AM
Script : http://www.runicgamesfansite.com/vbdownloads.php?do=file&fileid=1784&v=50460799876600
Referrer : http://www.runicgamesfansite.com/vbdownloads.php?do=file&fileid=1784
IP Address : 59.46.59.22
Username : Unregistered
Classname : vB_Database
MySQL Version :

However, so far it's just been those two after about four hours (roughly 400-500 guests using the database), so it doesn't happen very frequently. Hopefully you can figure out what is causing it though. Thanks as always!

 

[Fillip H.]

I've uploaded a potential hotfix for this issue.

Can you re-upload /dbtech/downloads/actions/file.php and /dbtech/downloads/includes/class_core.php and let me know if this works for you?

 

[Webbstre]

Thanks! I've just uploaded the files, though in the past 18 hours or so I only had those two errors come up. If it happens again I'll let you know, otherwise I guess we'll assume that it's fixed!