Bug Quotations in Download Name cause issues in url when using rewrites

[bzcomputers]

Quotations in any download name are causing url issues when being rewritten. The quotation is currently breaking the url link where it is inserted.

I see this for thumbnail urls, download page urls, and download urls referenced multiple places throughout the mod.

<a href="http://www.yoursite.com/forum/downloads/download-section/beginning-of-name-" quoted part"-the-rest-of-the-name thumbxxxxxxxxxx.html"
<a href="http://www.yoursite.com/forum/downloads/download-section/beginning-of-name-" quoted part"-the-rest-of-the-name-xx.html">

Looks like quotes need to be encoded or removed from rewrites.

 

[Fillip H.]

What's the value of the "Filter Non-Latin Characters" setting?

 

[bzcomputers]

What's the value of the "Filter Non-Latin Characters" setting?

Keep Non-Latin Characters

 

[Fillip H.]

Try changing it to Remove Non-Latin Characters, let me know if that works

 

[bzcomputers]

Try changing it to Remove Non-Latin Characters, let me know if that works

Yes, it will work with that setting change, but should this setting change be required in order to not break download urls that have titles with quotations in them?

Everywhere else forum rewrites , cms rewrites, etc. the quotations are automatically removed even with the setting of "Keep Non-Latin Characters". It just seems to be an issue with Downloads rewrites.

 

[Fillip H.]

True, but it's a stop-gap measure if nothing else

I'll post back when a fix is available

 

[Fillip H.]

Update: I've made a hotfix that should resolve this issue. If you re-download the latest version of vBDownloads and re-upload /dbtech/dbseo/includes/library/vbdownloads.php the URLs should no longer have quotes in them.

 

[bzcomputers]

Could any change in this file have caused download permission issues? It appears since I updated this file I have been having permission issues for downloads ...trying to track it down now.

Update: I was previously on 2.2.0pl1 and upgraded to 2.2.0pl2 when this fix was released. Now all downloads threads are giving access errors (admins and guests - which should all have access). Settings for each download category shows permissions are granted for these users also.

Update 2: It appears the errors I'm seeing are coming from all my downloads that end in a date. Which would be the ones that previously were appended with a "-a" prior to the download id. These file links no longer have the "-a" and are giving permission errors because of this. If I manually add the "-a" into the url prior to the id the page appears to render correctly for all users.

Update 3: Since it appears it may be unrelated to this post. I will start a new thread with the details above. http://www.dragonbyte-tech.com/f80/download-permission-errors-all-files-ending-number-14356/