Bug Invalid template modification in 1.2.3

[Liam W]

When upgrading to 1.2.3 (from 1.2.1), this error appears:

Please enter a valid regular expression.

Testing it, it appears to be the PAGE_CONTAINER template mods that are causing the issue. The actual error from the regex (tested in a separate file) is:

Compilation failed: invalid range in character class at offset 54 in /Users/liam/test.php on line 7

Liam

P.S You need to update your Guzzle usage for XF 2.1 - it's using Guzzle 6 now.

 

[Liam W]

It's a PHP 7.3 change. They upgraded to PCRE2...

You need to escape the hyphen in the character set.

(I'm downgrading to PHP 7.2 for now)

 

[Fillip H.]

The current release version of eCommerce does not support 2.1, I have an internal build that runs on 2.1 with all the surrounding changes but it will not be released until 2.1 is in the RC stage. That is also the time we plan to upgrade this site

I don't believe XF2 supports PHP 7.3 just yet, does it? In either case, I don't have the ability to test it just now as my Docker image for 7.3 won't compile due to broken libraries.

I'm constantly monitoring it and will be making a full effort into getting a 7.3 environment up and running as soon as XF2 launches full support for 7.3.

 

[Fillip H.]

Just a quick update to let you know I've switched to 7.3 for my local development board as Memcached un-hecked their releases so my Docker image now compiles

I've fixed the template modification issue, and hotfixed v1.2.3. I'll be releasing v1.2.4 with this fixed & other features in the coming days.

I can't guarantee that the rest of the mod works with 7.3 but at least the upgrade should complete

 

[DragonByte Technologies]

Hello @Liam W,

We hope your ticket regarding DragonByte eCommerce has been addressed to your satisfaction. This ticket has now been closed.

If your ticket has not been resolved, you can reply to this thread at any point in the next 7 days in order to reopen the ticket, afterwards this thread will be closed.

Please do not reply to this thread if your ticket has been resolved.

Thank you.


- DragonByte Technologies, Ltd.