Bug Invalid Navbits HTML

[vaultwiki]

The template dbtech_dbseo_navbit_link contains improperly nested and thus invalid HTML:

<div itemscope="itemscope" itemtype="http://data-vocabulary.org/Breadcrumb">
	<li class="navbit"><a href="{vb:raw nav_url}" itemprop="url"><span itemprop="title">{vb:raw nav_title}</span></a></li>
</div>

This should be:

	<li class="navbit" itemscope="itemscope" itemtype="http://data-vocabulary.org/Breadcrumb"><a href="{vb:raw nav_url}" itemprop="url"><span itemprop="title">{vb:raw nav_title}</span></a></li>

An LI can only be inside UL or OL, not a DIV.

 

[Fillip H.]

Hi there,

Does this cause any display issues in any browsers you have found?

 

[vaultwiki]

This has caused some features of other add-ons on my site to break. When I make the HTML valid again, the add-ons all work as expected.

Aside from other add-ons, this issue has the potential to break custom CSS rules or Javascript that expects the parent of an LI to be the actual list element (which it should be).

There are many reasons to write valid HTML, even if you don't think they cause a problem now: Why Validate Your Pages?

 

[Fillip H.]

I asked because if it was causing any issues (like the add-on breaking you mentioned) I would hotfix it today, which I have done for v2.0.29

Also to be fair, that site is trying to sell you a HTML validator, so I take what they say with a grain of salt To be clear, I'm not saying "to hell with validation", but if the issue was not causing any actual issues other than failing a validator, I wouldn't make it a priority issue to fix.

 

[DragonByte Technologies]

Hello vaultwiki,

This ticket has now been closed with the status Fixed.

We hope your issue or question has been addressed to your satisfaction. If not, please feel free to re-open it by clicking this link.

If you have any further issues or questions, please feel free to start a new support ticket via the button at the top of every page.

Thank you!