Question Your help integrating another modification

[Mick]

Hi again ,

I am integrating itraders into this modification and just wondered if someone could help me with a small plugin

Have a look how far I have got so far:

For Sale. RGH Halo4 Slim

You can see the classifieds feedback just above the attachments

This is only visible in the classifieds forums of course

However,

I am looking to add a plugin for the showthreads page to be able to get the percentage score as you can see it just shows a percentage.


Here is my thinking

$tradepcnt = $vbulletin->db->query_first_slave("
		SELECT itrader_pcnt
		FROM " . TABLE_PREFIX . "itrader
		WHERE $thread['userid'] = " . $userinfo['userid'] . "
	");

vB_Template::preRegister('showthread',array('tradepcnt' => $tradepcnt));

Would that work, and what would be the implications of such a query?

Regards
Mick

 

[Fillip H.]

If you add that query to showthread_query (and not postbit_display_complete or some other looped plugin) there should be zero implications beyond the 0.0001 seconds it takes to execute that query ;P

That being said, the query seems to be invalid. My guess is, you meant to do something like

WHERE userid = " . $thread['userid'] . "

instead?

 

[Mick]

Yes I actually wrote that while looking at the code in notetab. and on here.

Going to test it now...

Thank you... was a little worried about it being in a loop but your plugin hook suggestion sounds great

Regards
Mick

 

[Mick]

Tried both

$thread['userid']
and
$threadinfo['userid']

Trying to pull the first posters userid

Regards
Mick

 

[Mick]

$threadinfo[userid]

this did work I was pulling the data from the wrong table.. should of been the user table...

I am going to wrap the code around a

if forumid = classifieds forums array aswell so its not called unless its in them forums, is that sensible ?

Regards
Mick

 

[Fillip H.]

I'm not sure I understand your question, but you can ensure the code doesn't run in any forums other than the ones you want by doing

if (in_array($threadinfo['forumid'], array(x, y, z, a, b, c)))
{
// Code goes here
}

 

[Mick]

Yeah that is perfect, I was just wondering if that would be better than an SQL call for every showthread call page load?

Also the

$threadinfo['userid']

Breaks the SQL?

Do you have any idea which variable is used to store the USERID in showthread... I have looked in showthread.php and found

$threadinfo['postuserid']

But that is not displaying anything ?

Regards
Mick

 

[Mick]

Sorry about the amount of posts.

I have this working fully now

$threadinfo['postuserid'] is correct

For Sale. RGH Halo4 Slim

As you can see it also pulls the percentage from the database.

Thanks so much Fillip H. not sure I would of gotten there without you!

Mick

 

[Fillip H.]

No problem