Bug "View" event trigger not apply to transactions!

[e-Dewan]

Hi Dragons ,



As you see on the above screenshot,
"View" event is triggered, But not calculated to the total balance amount!
I have double checked all settings including "View" events settings and all correct and same as other events.

​

DragonByte Credits 5.7.3.1
Xenforo v2.2.5

---

Also I have created a wallet widget to display a specific currency, But the widget always display either the all currency or the 1st currency I created, How can I only display the 2nd currency only?
I already choose to display the 2nd currency only in the widget sitting but not working

(ACP is dark themed)

 

[e-Dewan]

It's been two days & still no reply!!

 

[e-Dewan]

Help!! Every member is complaining in my forums about this issue.
I hope every one in DragoneByte is ok.

 

[Fillip H.]

Are you sure those transactions aren't flagged as moderated?

 

[e-Dewan]

Are you sure those transactions aren't flagged as moderated?

Yes, Not moderated

 

[e-Dewan]

Hi,

Sorry for inconvenience, I am still awaiting your response.

 

[Fillip H.]

I don't have any new information to share at this time. I will let you know if I'm able to reproduce it and if not, if I need any additional information.

 

[e-Dewan]

I've paid $80 to a developer to fix these 2 issues. Making me rethink & reconsidering about next renewal of your add-ons.

---

Here is what developer did to fix the bugs.

DragonByte Wallet issue:
Wallet not showing correct selected currency.

Reason:
Values against select options are not correct... And its a really bad approach that has been used, it creates more and more conflicts if used more currencies...

Solution:
Passed correct parameters to the widget template and used them in a correct way.

Changes:
1. DBTech\Credits\Widget\Wallet:
Replace

protected function getDefaultTemplateParams($context): array
    {
        $params = parent::getDefaultTemplateParams($context);
        if ($context == 'options')
        {
            $params['currencies'] = $this->finder('DBTech\Credits:Currency')
                ->fetch()
                ->pluckNamed('title')
            ;
        }
        return $params;
    }

With

protected function getDefaultTemplateParams($context): array
    {
        $params = parent::getDefaultTemplateParams($context);
        if ($context == 'options')
        {
            $params['currencies'] = $this->finder('DBTech\Credits:Currency')
                ->fetch()
            ;
        }
        return $params;
    }

2. Template(widget_def_options_dbtech_credits_wallet):

Replace

<hr class="formRowSep" />

<xf:selectrow label="{{ phrase('dbtech_credits_currency_limit') }}" name="options[currencyIds][]" value="{{ $options.currencyIds ?: '' }}" multiple="multiple" size="7">
    <xf:option value="">{{ phrase('dbtech_credits_all_currencies') }}</xf:option>

    <xf:options source="$currencies" />

    <xf:explain>{{ phrase('dbtech_credits_only_include_selected_currencies') }}</xf:explain>
</xf:selectrow>

With

<hr class="formRowSep" />



<xf:selectrow label="{{ phrase('dbtech_credits_currency_limit') }}" name="options[currencyIds][]" value="{{ $options.currencyIds ?: '' }}" multiple="multiple" size="7">

    <xf:eek:ption value="">{{ phrase('dbtech_credits_all_currencies') }}</xf:eek:ption>

    <xf:foreach loop="$currencies" value="$currency">

        <xf:eek:ption value="{$currency.currency_id}">{$currency.title}</xf:eek:ption>

    </xf:foreach>

  



    <xf:explain>{{ phrase('dbtech_credits_only_include_selected_currencies') }}</xf:explain>

</xf:selectrow>

---

DragonByte Viewed Event Points Issue:

Reason:
bad query in Transaction Entity if 'Disallow negative currency' option is selected in currency.

if (!$this->Currency->negative)
            {
                // Update the currency table, but ensure it resets to 0 if needed
                $this->db()->query('
                    UPDATE xf_user
                    SET ' . $this->Currency->column . ' = GREATEST(0, CAST(' . $this->Currency->column . ' AS SIGNED) + ?)
                    WHERE user_id = ?
                ', [
                    $this->amount,
                    $this->user_id
                ]);
            }

Solution:
We don't have the need to select this option so we have changed it to 'Allow negative display' for now. When they fix, you can choose anyone.

the error is attached below.

 

[Fillip H.]

DragonByte Wallet issue:
Wallet not showing correct selected currency.

Reason:
Values against select options are not correct... And its a really bad approach that has been used, it creates more and more conflicts if used more currencies...

Solution:
Passed correct parameters to the widget template and used them in a correct way.

This solution is over-engineered. The real fix is to change line 34 to ->pluckNamed('title', 'currency_id').

---
I would prefer it if you kept insulting statements out of future posts, as it's making it much harder for me to assist you further.