Bug Typo in category breadcrumbs

[kick]

public function getBreadcrumbs($includeSelf = true, $linkType = 'public')
    {
        if ($linkType == 'public')
        {
            $link = 'dbtech-ecommerce/categories';
        }
        else
        {
            $link = 'dbtech-ecommerce/categories';
        }
        return $this->_getBreadcrumbs($includeSelf, $linkType, $link);
    }

 

[Fillip H.]

Can you please provide more information? It is not clear what you are reporting from simply posting a code snippet.

 

[kick]

I provided a code where the condition doesn’t make any difference at all, since the same thing will always return
What is the difference from the type of link if it returns the same thing for everything?

if ($linkType == 'public')
        {
            $link = 'dbtech-ecommerce/categories';
        }

Well, if our link type is not public, what next? We have a condition

else
        {
            $link = 'dbtech-ecommerce/categories';
        }

And we get the same link. The question is, why then is this condition necessary? It makes no sense extra code

 

[Fillip H.]

Then that's not a typo. A typo is a misspelling.

This was originally separated because the routes were different in the AdminCP vs front-end, and there's no reason to change this.