Bug Missing order_id in OrderEmail job.

[Liam W]

My error logs have been filling with the following:

LogicException: Cannot trigger this job without a valid order id.
src/addons/DBTech/eCommerce/Job/OrderEmail.php:35

#0 src/XF/Job/AbstractJob.php(28): DBTech\eCommerce\Job\OrderEmail->setupData(Array)
#1 src/XF/Container.php(275): XF\Job\AbstractJob->__construct(Object(XF\Pub\App), 14959, Array)
#2 src/XF/App.php(1534): XF\Container->createObject('DBTech\\eCommerc...', Array, true)
#3 src/XF/Container.php(228): XF\App->XF\{closure}('DBTech\\eCommerc...', Array, Object(XF\Container))
#4 src/XF/App.php(2732): XF\Container->create('job', 'DBTech\\eCommerc...', Array)
#5 src/XF/Job/Manager.php(231): XF\App->job('DBTech\\eCommerc...', 14959, Array)
#6 src/XF/Job/Manager.php(236): XF\Job\Manager->getJobRunner(Array)
#7 src/XF/Job/Manager.php(195): XF\Job\Manager->runJobInternal(Array, G)
#8 src/XF/Job/Manager.php(79): XF\Job\Manager->runJobEntry(Array, G)
#9 job.php(42): XF\Job\Manager->runQueue(false, 20)
#10 {main}

array(4) {
  ["url"] => string(8) "/job.php"
  ["referrer"] => string(22) "https://lw-addons.net/"
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(0) {
  }
}

 

[Fillip H.]

Can you check your settings to see if perhaps you've configured the "Delete pending orders older than..." setting to have an effective value smaller than the "Send email reminders for pending orders older than..." setting?

For instance, if orders are deleted after 7 days but email reminders are set for 14 days.

I'll look into cancelling the reminder emails when an order is deleted, but for now it might be worth looking into whether this could be the issue.

 

[Liam W]

Nope, email reminders sent after 2 days, orders deleted after 7 days - though I did decrease the orders deleted value around the time I noticed these start to appear.

 

[Fillip H.]

Perhaps there was a small window of time where the above was true

In either case, the entry in xf_job should be fairly easy to pick out, they probably have to be deleted manually.

I'll also look into just completing the job if the order_id param exists but doesn't resolve to an actual order, just in case. EDIT: Nope that doesn't work, the error is triggered in setupData which can't complete jobs.

 

[DragonByte Technologies]

Hello @Liam W,

We hope your ticket regarding DragonByte eCommerce has been addressed to your satisfaction. This ticket has now been scheduled to be closed.

If your ticket has not been resolved, you can reply to this thread at any point in the next 7 days in order to reopen the ticket, afterwards this thread will be closed.

Please do not reply to this thread if your ticket has been resolved.

Thank you.


- DragonByte Technologies, Ltd.

 

[DragonByte Technologies]

Hello @Liam W,

As we have not heard back from you, your ticket regarding DragonByte eCommerce has now been closed.

If your ticket has not been resolved, please feel free to start a new support ticket and link back to this ticket.

If you have time, please leave a review on XenForo.com's Resource Manager.

Thank you.


- DragonByte Technologies, Ltd.