Bug 'Start conversation when gifted' setting does not send conversation on gift

[fearmywrench]

When the 'Start conversation when gifted' setting is turned on for an item, no conversation is sent when the item is gifted to another user. There is an alert sent, but this alert is sent regardless of this setting being turned on or off, so I don't think it's related. An alert is also a temporary notification that disappears soon after whereas a conversation is more permanent.

 

[Fillip H.]

I've updated this on the test site just now.

While it's untested, I'm reasonably certain it'll work during checkout, but I'm not sure how well it'll work when gifting via the inventory.

I've implemented 4 different permutations of the gift notification PM body:

1. No gift message / no configuration
2. Gift message / no configuration
3. No gift message / configuration
4. Gift message / configuration

Ideally, #3 and #4 would only be possible via the inventory, since it is possible to gift an item that has been configured.

Let me know if you encounter any problems

 

[fearmywrench]

I've tested what I believe is every possible version -- looks to be working almost perfectly!

Only one tiny bug caught my eye: on the User Title Style Change item, it looks like the displayed Shadow style configuration in the conversation is actually displaying the color value instead.





Very minor but now after uploading the screenshots in here, I also see some inconsistencies in the naming of the values too if you care about that haha. (color vs colour, Glow vs Glow color, Shadow vs Shadow color)

---

Separately from that, I have a couple other comments although admittedly these are probably more feature requests than bugs, but they are mostly pretty minor so I'll just drop them in here in case you think any of them are easy enough and worth throwing in:

• It would be helpful if the item's name was included in the gift conversation title, particularly when scanning down your conversation inbox.
• It would look cleaner and potentially less confusing if the entire configuration section was removed if the item has no possible configurations. (like a Custom Item with no custom fields) Currently, there's a "The item is configured with the following values:" line with a couple empty line breaks below it.
• It might make sense to disable the regular gift alert if the conversation setting is enabled, so there aren't double alerts/messages sent. Or even replace the alerts entirely with conversations, so there is just no alert or message at all if the conversation setting isn't enabled, thereby turning the setting into basically an option to turn on or off gifting notifications in general for the item.

 

[Fillip H.]

Only one tiny bug caught my eye: on the User Title Style Change item, it looks like the displayed Shadow style configuration in the conversation is actually displaying the color value instead.

This is currently working as intended. Anywhere the configuration value is displayed, it's displayed as the raw value.

Very minor but now after uploading the screenshots in here, I also see some inconsistencies in the naming of the values too if you care about that haha. (color vs colour, Glow vs Glow color, Shadow vs Shadow color)

Sure, I can clean that up since XF uses English (US) as default.

It would be helpful if the item's name was included in the gift conversation title, particularly when scanning down your conversation inbox.

You can edit this yourself in the phrases, the available replacement variables that make sense for titles are:

• {user} (the buyer)
• {item} (item name)

If you have a specific suggestion for what the phrase should contain, feel free to let me know.

It would look cleaner and potentially less confusing if the entire configuration section was removed if the item has no possible configurations.

That is the intended functionality. If this is not the case, please let me know how to replicate this (specifically which item type and how is the item configured in the AdminCP).

It might make sense to disable the regular gift alert if the conversation setting is enabled, so there aren't double alerts/messages sent.

Sure, I'll implement that in the next build.

 

[fearmywrench]

This is currently working as intended. Anywhere the configuration value is displayed, it's displayed as the raw value.

I think you may have misunderstood me. What I meant is that the shadow is not configured/set on that item, but is displaying one anyway in the conversation, specifically the color value. (the second screenshot is the configuration grabbed from inventory) My theory was that the color value is being incorrectly displayed for the shadow value, but I could be way off there!

It would be even better to be honest if the fields which aren't set as configurable for an item (in this case, only color is) just weren't listed at all so the users aren't teased with their existence when they can't use them, but I understand why that might be the case.

You can edit this yourself in the phrases, the available replacement variables that make sense for titles are:

• {user} (the buyer)
• {item} (item name)

If you have a specific suggestion for what the phrase should contain, feel free to let me know.

That's perfect thank you! By any chance is there a list of DBShop/Credits replacement values anywhere, or could you consider producing one in the future? If there's one for the item description, that would be great for including in the body too -- vBShop's PMs have that.

That is the intended functionality. If this is not the case, please let me know how to replicate this (specifically which item type and how is the item configured in the AdminCP).

I'm seeing it on a Custom Item with no custom fields setup. On our test site, the Red Balloon item is setup like this -- I gifted your test account one.

 

[Fillip H.]

What I meant is that the shadow is not configured/set on that item, but is displaying one anyway in the conversation, specifically the color value.

What has probably happened here is the following sequence of events:

1. All colour options were initially available
2. The item was configured with all colour options
3. The "shadow" colour option was then disabled by the admin
4. The item was gifted without re-configuring the item first

What this means is that internally, the "shadow" colour is actually still configured. It only gets reset to a blank value if you were to configure the item after the option was disabled in the item settings.

The reason why the inventory says "not set" is that the inventory checks for both the admin option and the configured value - in other words, if the admin option is turned off, it'll say "not set" even if internally the configured value still exists.

This issue affected all 4 style items (User Title Style, User Name Style, Thread Title Style and Post Style) and will be fixed in the next build.

It would be even better to be honest if the fields which aren't set as configurable for an item (in this case, only color is) just weren't listed at all so the users aren't teased with their existence when they can't use them, but I understand why that might be the case.

That would not be feasible, as the list of values is a phrase (so that it can be translated and the BBCode customised). It would necessitate 6² different phrases (6 inputs with 2 possible permutations each, for a total of 36 phrases).

By any chance is there a list of DBShop/Credits replacement values anywhere, or could you consider producing one in the future?

Sorry, I don't understand the question. What replacement variables are available is entirely dependent on each individual phrase, there isn't a "master list" anywhere.

I'm seeing it on a Custom Item with no custom fields setup. On our test site, the Red Balloon item is setup like this -- I gifted your test account one.

I'll look into that and get back to you. Meanwhile, does it affect any other item types that you've found?

 

[Fillip H.]

I'm seeing it on a Custom Item with no custom fields setup. On our test site, the Red Balloon item is setup like this -- I gifted your test account one.

Update: I found the reason and uploaded a new build, let me know if it still occurs

 

[fearmywrench]

What has probably happened here is the following sequence of events:

1. All colour options were initially available
2. The item was configured with all colour options
3. The "shadow" colour option was then disabled by the admin
4. The item was gifted without re-configuring the item first

What this means is that internally, the "shadow" colour is actually still configured. It only gets reset to a blank value if you were to configure the item after the option was disabled in the item settings.

The reason why the inventory says "not set" is that the inventory checks for both the admin option and the configured value - in other words, if the admin option is turned off, it'll say "not set" even if internally the configured value still exists.

This issue affected all 4 style items (User Title Style, User Name Style, Thread Title Style and Post Style) and will be fixed in the next build.

Unclear if this fix is already in the newly uploaded build or not, but if it is, I'm not seeing it fixed. Additionally, I tried making a brand new item with only color enabled from the beginning and no further changes to confirm if that is the issue, and I still see the shadow issue. It's called "User Title Color Change 3.0" on the test site.

That would not be feasible, as the list of values is a phrase (so that it can be translated and the BBCode customised). It would necessitate 6² different phrases (6 inputs with 2 possible permutations each, for a total of 36 phrases).

Gotcha, that makes sense

Sorry, I don't understand the question. What replacement variables are available is entirely dependent on each individual phrase, there isn't a "master list" anywhere.

Gotcha. Sorry, I think I edited this in after you already started replying, but specifically is there a item description replacement value and if not could that be considered? vBShop Gift PMs contain the item description so that would be good to retain.

I tested {item_description} and {description} myself first just in case it exists already and is super obvious.

I'll look into that and get back to you. Meanwhile, does it affect any other item types that you've found?

Update: I found the reason and uploaded a new build, let me know if it still occurs

Custom Item configuration conversation issue looks to be resolved!

 

[Fillip H.]

Unclear if this fix is already in the newly uploaded build or not, but if it is, I'm not seeing it fixed. Additionally, I tried making a brand new item with only color enabled from the beginning and no further changes to confirm if that is the issue, and I still see the shadow issue. It's called "User Title Color Change 3.0" on the test site.

The issue was actually in the phrases, not in the code. I've uploaded a new build.

Gotcha. Sorry, I think I edited this in after you already started replying, but specifically is there a item description replacement value and if not could that be considered?

I've added that, as well as made various other phrase updates. Custom messages in notification conversations are now always in quotes and a few _nomessage phrases were added for scenarios where there were no messages along with the purchase.

 

[fearmywrench]

I'm not seeing the phrase updates if you uploaded those changes, although I might be looking in the wrong place -- not super familiar with the XF phrase system.

Shadow issue is all good

 

[DragonByte Technologies]

Hello @fearmywrench,

We hope your ticket regarding DragonByte Shop has been addressed to your satisfaction. This ticket has now been closed.

If your ticket has not been resolved, you can reply to this thread at any point in the next 7 days in order to reopen the ticket, afterwards this thread will be closed.

Please do not reply to this thread if your ticket has been resolved.

Thank you.


- DragonByte Technologies, Ltd.