Bug Entering characters into the Transaction ID field (Transaction Log)

[ichpen]

Small issue but can be handled better. Entering a non numeric character into the transaction log->transaction ID field produces the below. Ideally we should pop up a normal validation error here.

• ErrorException: [E_WARNING] A non-numeric value encountered
• src/XF/Searcher/AbstractSearcher.php:485
• Generated by:
• Nov 23, 2018 at 7:55 AM

Stack trace
#0 src/XF/Searcher/AbstractSearcher.php(485): XF::handlePhpError(2, '[E_WARNING] A n...', '/home/nginx/dom...', 485, Array)
#1 src/XF/Searcher/AbstractSearcher.php(439): XF\Searcher\AbstractSearcher->castValueToColumnType('spddmon', 2)
#2 src/XF/Searcher/AbstractSearcher.php(394): XF\Searcher\AbstractSearcher->applyCriteriaValue(Object(DBTech\Credits\Finder\Transaction), 'transaction_id', 'spddmon', Array, NULL, NULL)
#3 src/XF/Searcher/AbstractSearcher.php(361): XF\Searcher\AbstractSearcher->applyCriteria(Object(DBTech\Credits\Finder\Transaction), Array)
#4 src/addons/DBTech/Credits/Admin/Controller/Log.php(79): XF\Searcher\AbstractSearcher->getFinder()
#5 src/XF/Mvc/Dispatcher.php(249): DBTech\Credits\Admin\Controller\Log->actionTransaction(Object(XF\Mvc\ParameterBag))
#6 src/XF/Mvc/Dispatcher.php(88): XF\Mvc\Dispatcher->dispatchClass('DBTech\\Credits:...', 'Transaction', 'html', Object(XF\Mvc\ParameterBag), 'dbtechCrTxnLog', Object(DBTech\Credits\Admin\Controller\Log), NULL)
#7 src/XF/Mvc/Dispatcher.php(41): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#8 src/XF/App.php(1931): XF\Mvc\Dispatcher->run()
#9 src/XF.php(329): XF\App->run()
#10 admin.php(13): XF::runApp('XF\\Admin\\App')
#11 {main}
Request state
array(4) {
["url"] => string(44) "/admin.php?dbtech-credits/logs/transactions/"
["referrer"] => string(84) "https://mysite.com/admin.php?dbtech-credits/logs/transactions/search"
["_GET"] => array(1) {
["dbtech-credits/logs/transactions/"] => string(0) ""
}
["_POST"] => array(4) {
["criteria"] => array(6) {
["transaction_id"] => string(7) "spddmon"
["SourceUser"] => array(1) {
["username"] => string(0) ""
}
["TargetUser"] => array(1) {
["username"] => string(0) ""
}
["dateline"] => array(2) {
["start"] => string(0) ""
["end"] => string(0) ""
}
["event_trigger_id"] => string(4) "_any"
["event_id"] => string(4) "_any"
}

 

[Fillip H.]

Keeping this open as I've generated a XF 2.1 branch for this mod as well so fixing it will take some extra time.

In the future, the transaction ID box will use a numberbox, and your browser should verify that it's a number before submitting (so long as your browser supports number inputs).

 

[Fillip H.]

This'll be resolved in the next version:

 

[DragonByte Technologies]

Hello @ichpen,

We hope your ticket regarding DragonByte Credits has been addressed to your satisfaction. This ticket has now been closed.

If your ticket has not been resolved, you can reply to this thread at any point in the next 7 days in order to reopen the ticket, afterwards this thread will be closed.

Please do not reply to this thread if your ticket has been resolved.

Thank you.


- DragonByte Technologies, Ltd.