Bug Add rel="nofollow" to External URLs

Status
Not open for further replies.

motd2

Customer
Add rel="nofollow" to External URLs
Set - yes

in vB3 - not work
Code:
test for vB3 <a href="http://www.dragonbyte-tech.com/forum.php" target="_blank">DragonByte Tech | vBulletin Mods & Addons</a>

in vB4 - its ok
Code:
test for vB4 <a rel="nofollow" href="http://www.dragonbyte-tech.com/forum.php" target="_blank">DragonByte Tech | vBulletin Mods & Addons</a>
 
I'm unable to replicate this issue. I posted a link to Google in a thread on my vB3 test forum, turning the setting on and off changed the nofollow flag as expected.

Can you please provide step-by-step instructions for how to replicate this issue?
 
External Links
Add rel="nofollow" to External URLs -> Yes
Anonymise External URLs -> No
Excluded Forums -> No
Domain Whitelist -> No
Domain Blacklist -> No
 
Update:
DragonByte SEO v1.3.5
Add rel="nofollow" to External URLs & Anonymise External URLs - works fine

v1.3.6 and and older - not works
 
I am testing this on v1.4.3 and I cannot replicate this issue. Can you please try updating to the latest version?
 
Update to v1.4.3
dbtech/dbseo/includes/class_core.php
line 2704-2763
Code:
[COLOR="#FF0000"]		if (isset(self::$cache['_objectIds']) AND count(self::$cache['_objectIds']))
		{[/COLOR]
			if (isset(self::$config['dbtech_dbseo_rewrite_texturls']) AND self::$config['dbtech_dbseo_rewrite_texturls'])
			{
				// Replace text urls in content
				$content = preg_replace_callback(
					'#(' . str_replace('tps\:','tps?\:', preg_quote(self::$config['_bburl'], '#')) . '/?)([^<\]\[\"\)\s]*)#is', 
					array('DBSEO', 'replaceTextUrls'), 
					$content
				);
			}

			if (self::$config['_isXML'])
			{
				// Replace text urls in XML
				$content = preg_replace_callback( 
					'#(<link>(?:\<\!\[CDATA\[)?)([^<\]]*)#is',
					array('DBSEO', 'replaceTextUrls'), 
					$content
				);
			}

			// Do main content replacements
			$content2 = preg_replace_callback( 
				'#(value="(?:\[.*?\])?)(' . preg_quote(self::$config['_bburl'], '#') . '/?)([^<\]\[\"\)\s]*)#is',
				array('DBSEO', 'replaceMainContent'), 
				$content
			);

			// Ensure we only overwrite content if it's valid
			$content = $content2 ? $content2 : $content;

			if (!isset(self::$config['dbtech_dbseo_rewrite_texturls']) OR !self::$config['dbtech_dbseo_rewrite_texturls'])
			{
				$content = preg_replace_callback(
					'#(<(?:a|span|iframe|form|script|link|img|meta)([^>]*?)(?:href|src|action|url|\.open|\.location|content)\s*[=\(]\s*["\'])([^"\'>\)]*)(.*?[\>])([^<]*)(</a>)?#is',
					array('DBSEO', 'replaceTags'), 
					$content
				);

				if (!self::$config['_inAjax'] AND isset(self::$cache['urlReplace']))
				{
					// Start fresh!
					unset(self::$cache['urlReplace']);
				}

				if (strpos($_SERVER['REQUEST_URI'], 'printthread.php') !== false)
				{
					// Ensure we're doing this
					self::$config['_rewritePrintThread'] = 1;

					// Replace the text URLs again
					$content = preg_replace_callback(
						'#(\([^\)]*?(?:http://)?[^\)]*?)(' . preg_quote(self::$config['_bburl'], '#') . '/[^<\)]*)#is',
						array('DBSEO', 'replaceTextUrls'), 
						$content
					);
				}
			}
[COLOR="#FF0000"]		}[/COLOR]
remove here red color - all works
maybe it's just me
 
That code is required, so this is not a valid fix unfortunately :(

Can you try disabling all non-DBTech products temporarily and see if that resolves it for you? You may have a mod conflict somewhere.
 
Disable all non-DBTech products & DBTech products
Only DragonByte SEO v1.4.3 enable. Not work :)

Ok, close this to new versions.
 
Could you please create and PM me with a temporary FTP and AdminCP account?

For security reasons, we recommend you create a new FTP account only for DBTech support, then disable or delete it after we have both confirmed the issue has been solved and there are no further issues.

The same applies to AdminCP accounts; they should ideally be temporary accounts created for us only. If we have created an account on your site already, you can optionally boost that account to Administrator and then de-admin this account once the issue has been solved.

If you use a .htaccess password protection for your AdminCP directory, it is recommended that you create a new authorised user for DBTech and remove this user once the issue has been solved.

Please test any temporary accounts you create to ensure that the FTP account has access to the forum files, and that the AdminCP account can access the administrative controls for the product we are assisting you with.

Ensuring this is all in order before submitting the information will significantly speed up the process of assisting you. We will alert you via PM if there's any issues with the login information you have provided.

When sending the PM, for your security you should also un-tick the "Save a copy in my Sent Items folder" checkbox. When the access details have been received, we will delete the PM from our inbox. Ensuring you have not kept a copy of the PM reduces the risk of security breaches.

Thank you for helping us debug our products and allowing us to assist you, we appreciate it :D
 
The reason why this is not working for you is the fact that you have turned off all URL rewrites. At least 1 URL rewrite must be enabled in order for this functionality to work.

This is working as intended :)
 
Status
Not open for further replies.

Legacy DragonByte SEO

vBulletin 3.8.x vBulletin 4.x.x
Seller
DragonByte Technologies
Release date
Last update
Total downloads
7,173
Customer rating
5.00 star(s) 1 ratings
Top