Bug User Title Change - debugged

Status
Not open for further replies.
Website
http://www.google.com
Product version
1.0
Forum version
vBulletin 4.2.x
#1
I've seen several posts here complaining that custom user titles are deleted/overwritten frequently, making this item pointless. I've debugged it and would like to show how this can be replicated and fixed:

When changing a user title, vbshop sets vbulletin to recognize this as "yes, user set" which you can see on the user page in the admincp.

If that person does not belong to a usergroup that has "Can Use Custom Title" set to YES, vBulletin will erase the custom title the next time it updates user titles / ranks. If they do belong to a usergroup with "Can Use Custom Title" the vbshop title will stay with no problems.


However if "Can Use Custom Title" is set to "YES", there's no real reason to buy it in the vbshop :)

I considered editing the code to switch "yes, user set" to "yes, admin set (html allowed)" - as this is NEVER overwritten on updates, but this could open up exploits due to the html.

The easiest fix is cosmetic: allow all usergroups to set custom titles, and then hide the option to change user titles in the usercp.

Example for vb 4.2:

template: modifyprofile

change
Code:
			<vb:if condition="$show['customtitleoption']">
				<div class="blockrow">					
					<label for="tb_customtext">{vb:rawphrase custom_user_title}:</label>
					<div class="rightcol">
						<p class="label">{vb:rawphrase your_current_user_title_is}</p>
						<div id="customtitle">
							<span id="currentcustomtitle">{vb:raw bbuserinfo.usertitle}</span>
							<label for="cb_resettitle" id="resetcustomtitle">
								<input type="checkbox" name="resettitle" value="yes" id="cb_resettitle" tabindex="1" /> {vb:rawphrase reset}
							</label>					
						</div>
					</div>
					<p class="description">{vb:rawphrase title_appears_beneath_your_name}</p>
					<input type="text" class="primary textbox rightcol" name="customtext" id="tb_customtext" value="" maxlength="{vb:raw vboptions.ctMaxChars}" tabindex="1" />
				</div>
			</vb:if>

To

Code:
			<vb:comment><vb:if condition="$show['customtitleoption']">
				<div class="blockrow">					
					<label for="tb_customtext">{vb:rawphrase custom_user_title}:</label>
					<div class="rightcol">
						<p class="label">{vb:rawphrase your_current_user_title_is}</p>
						<div id="customtitle">
							<span id="currentcustomtitle">{vb:raw bbuserinfo.usertitle}</span>
							<label for="cb_resettitle" id="resetcustomtitle">
								<input type="checkbox" name="resettitle" value="yes" id="cb_resettitle" tabindex="1" /> {vb:rawphrase reset}
							</label>					
						</div>
					</div>
					<p class="description">{vb:rawphrase title_appears_beneath_your_name}</p>
					<input type="text" class="primary textbox rightcol" name="customtext" id="tb_customtext" value="" maxlength="{vb:raw vboptions.ctMaxChars}" tabindex="1" />
				</div>
			</vb:if> </vb:comment>
 
Last edited:

Belazor

Staff member
Owner
Developer
Customer
#2
At the moment, I'm going to say this is working as intended. Like you yourself said, using Admin Set option when setting titles opens the mod up to exploits, and because vBulletin does not have a good way of allowing mods to set user titles across the board, the way it works just now is the best option available to me.


EDIT: Could you please refrain from using fake URLs when creating the issue? As it says in the description, your URL is never revealed to the public even if you do not create a private support ticket. Adding fake URLs can lead to an increase in support time as it is policy not to respond to tickets with fake URLs - I simply didn't notice it before replying this time :)

Thank you!
 
#3
This wasn't a support post, just information for other users.

The item is either pointless (with unlimited custom titles on) or useless (they get overwritten/delted) - this fix makes it usable.
 

DragonByte Technologies

Company Information
Staff member
Company Info
#4
Hello Frybread,

This ticket has now been closed with the status Not A Bug.

We hope your issue or question has been addressed to your satisfaction. If not, please feel free to re-open it by clicking this link.

If you have any further issues or questions, please feel free to start a new support ticket via the button at the top of every page.

Thank you!
 
Status
Not open for further replies.

vBShop

vBulletin 3.8.x vBulletin 4.x.x
Seller
DragonByte Technologies
Release date
Last update
Total downloads
1,181
Customer rating
0.00 star(s) 0 ratings
Top