DragonByte Tech | vBulletin Mods & Addons - Powered by vBulletin





User Tag List

Thanks Thanks:  0
Likes Likes:  0
Dislikes Dislikes:  0
Results 1 to 4 of 4

Thread: User Title Change - debugged


Forum: vBShop Lite Support

Questions & Answers for vBShop.
Click here to buy!

  1. #1
    Junior Member
    Level 3 (2,276 Loyalty Points)

    User InfoThanks / Tagging InfoGifts / Achievements / AwardsActivity Stats
    Join Date
    Aug 2012
    Posts
    18
    Rep Power
    0

    Default User Title Change - debugged

    I've seen several posts here complaining that custom user titles are deleted/overwritten frequently, making this item pointless. I've debugged it and would like to show how this can be replicated and fixed:

    When changing a user title, vbshop sets vbulletin to recognize this as "yes, user set" which you can see on the user page in the admincp.

    If that person does not belong to a usergroup that has "Can Use Custom Title" set to YES, vBulletin will erase the custom title the next time it updates user titles / ranks. If they do belong to a usergroup with "Can Use Custom Title" the vbshop title will stay with no problems.


    However if "Can Use Custom Title" is set to "YES", there's no real reason to buy it in the vbshop

    I considered editing the code to switch "yes, user set" to "yes, admin set (html allowed)" - as this is NEVER overwritten on updates, but this could open up exploits due to the html.

    The easiest fix is cosmetic: allow all usergroups to set custom titles, and then hide the option to change user titles in the usercp.

    Example for vb 4.2:

    template: modifyprofile

    change
    Code:
    			<vb:if condition="$show['customtitleoption']">
    				<div class="blockrow">					
    					<label for="tb_customtext">{vb:rawphrase custom_user_title}:</label>
    					<div class="rightcol">
    						<p class="label">{vb:rawphrase your_current_user_title_is}</p>
    						<div id="customtitle">
    							<span id="currentcustomtitle">{vb:raw bbuserinfo.usertitle}</span>
    							<label for="cb_resettitle" id="resetcustomtitle">
    								<input type="checkbox" name="resettitle" value="yes" id="cb_resettitle" tabindex="1" /> {vb:rawphrase reset}
    							</label>					
    						</div>
    					</div>
    					<p class="description">{vb:rawphrase title_appears_beneath_your_name}</p>
    					<input type="text" class="primary textbox rightcol" name="customtext" id="tb_customtext" value="" maxlength="{vb:raw vboptions.ctMaxChars}" tabindex="1" />
    				</div>
    			</vb:if>

    To

    Code:
    			<vb:comment><vb:if condition="$show['customtitleoption']">
    				<div class="blockrow">					
    					<label for="tb_customtext">{vb:rawphrase custom_user_title}:</label>
    					<div class="rightcol">
    						<p class="label">{vb:rawphrase your_current_user_title_is}</p>
    						<div id="customtitle">
    							<span id="currentcustomtitle">{vb:raw bbuserinfo.usertitle}</span>
    							<label for="cb_resettitle" id="resetcustomtitle">
    								<input type="checkbox" name="resettitle" value="yes" id="cb_resettitle" tabindex="1" /> {vb:rawphrase reset}
    							</label>					
    						</div>
    					</div>
    					<p class="description">{vb:rawphrase title_appears_beneath_your_name}</p>
    					<input type="text" class="primary textbox rightcol" name="customtext" id="tb_customtext" value="" maxlength="{vb:raw vboptions.ctMaxChars}" tabindex="1" />
    				</div>
    			</vb:if> </vb:comment>
    Last edited by Frybread; 12th February 2017 at 03:42.
    0 0 0
     
    User Title Change - debugged Send PM  

  2. #2
    Founder
    Level 0 (0 Loyalty Points)
    Belazor's Avatar
    User InfoThanks / Tagging InfoGifts / Achievements / AwardsActivity Stats
    Join Date
    Dec 2009
    Location
    Glasgow, United Kingdom
    Age
    30
    Posts
    27,731
    Blog Entries
    13
    Rep Power
    10

    Default

    At the moment, I'm going to say this is working as intended. Like you yourself said, using Admin Set option when setting titles opens the mod up to exploits, and because vBulletin does not have a good way of allowing mods to set user titles across the board, the way it works just now is the best option available to me.


    EDIT: Could you please refrain from using fake URLs when creating the issue? As it says in the description, your URL is never revealed to the public even if you do not create a private support ticket. Adding fake URLs can lead to an increase in support time as it is policy not to respond to tickets with fake URLs - I simply didn't notice it before replying this time

    Thank you!
    Fillip Hannisdal
    Founder & Programming Director
    DragonByte Technologies http://www.DragonByte-Tech.com


    Please do not Private Message me with support requests or product questions. PMs are only for exchanging sensitive information (like FTP / AdminCP logins).
    Please do not Private Message me with business related queries (refunds, complaints, feedback, etc). Decado is the person to PM for those issues.
    Please do not Private Message Decado with support requests or forum errors.

    When I say "Hotfix Released" it means you should re-download the product and re-upload the files.
    Like our products? Want to be notified on social media networks when we release updates or new products? Click the buttons below to Like us on Facebook, Follow us on Twitter and Follow us on Google+!
    0 0 0
     
    User Title Change - debugged Send PM  

  3. #3
    Junior Member
    Level 3 (2,276 Loyalty Points)

    User InfoThanks / Tagging InfoGifts / Achievements / AwardsActivity Stats
    Join Date
    Aug 2012
    Posts
    18
    Rep Power
    0

    Default

    This wasn't a support post, just information for other users.

    The item is either pointless (with unlimited custom titles on) or useless (they get overwritten/delted) - this fix makes it usable.
    0 0 0
     
    User Title Change - debugged Send PM  

  4. #4
    Bot Poster
    Level 0 (0 Loyalty Points)

    User InfoThanks / Tagging InfoGifts / Achievements / AwardsActivity Stats
    Join Date
    Dec 2010
    Posts
    1,361
    Rep Power
    0

    Default

    Hello @Frybread,

    This ticket has now been closed with the status Not A Bug.

    We hope your issue or question has been addressed to your satisfaction. If not, please feel free to re-open it by clicking this link.

    If you have any further issues or questions, please feel free to start a new support ticket via the button at the top of every page.

    Thank you!
    0 0 0
     
    User Title Change - debugged Send PM  

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Similar Threads

  1. Add/Change Donator Title
    By CharlieDelta in forum vBDonate Lite Support
    Replies: 5
    Last Post: 15th July 2012, 04:42
  2. [vB 3.8.x] Add Custom user title change
    By tyteen4a03 in forum vBShop Lite Support
    Replies: 6
    Last Post: 25th April 2012, 00:45
  3. [vB 4.1.x] Change Nav-bar Title ? and shifting it ?
    By Mv.c9 in forum vBShop Lite Support
    Replies: 3
    Last Post: 20th April 2011, 01:33

Tags for this Thread

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
This website uses cookies
We use cookies to store session information to facilitate remembering your login information, to allow you to save website preferences, to personalise content and ads, to provide social media features and to analyse our traffic. We also share information about your use of our site with our social media, advertising and analytics partners.